Skip to content

Commit

Permalink
cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
joethorley committed Sep 19, 2022
1 parent aeb4dee commit 5f1832f
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 11 deletions.
7 changes: 1 addition & 6 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,7 @@

# hmstimer 0.2.1

- Same as previous version.


# hmstimer 0.2.0.9000

- Same as previous version.
- Fix CRAN tests.


# hmstimer 0.2.0
Expand Down
32 changes: 27 additions & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,30 @@ release 4.2.1

## Fixed CRAN Problems

> Result: NOTE
> Found the following HTML validation problems:
> flobr-package.html:23:4: Warning: <img> attribute "align" not allowed for HTML5
Fixed.
Version: 0.2.0
Check: tests
Result: ERROR
Running 'testthat.R' [4s]
Running the tests in 'tests/testthat.R' failed.
Complete output:
> library(testthat)
> library(hmstimer)
>
> test_check("hmstimer")
[1] "07:26:52 (+00:00:00 => 07:26:52)"
[1] "07:26:51 (+00:00:01 => 07:26:52)"
[ FAIL 1 | WARN 0 | SKIP 0 | PASS 103 ]

== Failed tests ================================================================
-- Failure (test-print.R:7:3): test tmr_print output ---------------------------
`output` does not match "07:26:50 (+00:00:01 => 07:26:51)".
Actual value: "[1] "07:26:51 (+00:00:01 => 07:26:52)""
Backtrace:
x
1. \-testthat::expect_match(...) at test-print.R:7:2
2. \-testthat:::expect_match_(...)

[ FAIL 1 | WARN 0 | SKIP 0 | PASS 103 ]
Error: Test failures
Execution halted
Flavor: r-oldrel-windows-ix86+x86_64

0 comments on commit 5f1832f

Please sign in to comment.