Reduce permissions for app configuration #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @silkeh, Although I'm not using this module in production anymore, I can deploy a new version to the forge. Could you please fix the failing tests first? Thx and cheers! |
Having the app configuration world readable may expose the content of more sensitive environment variables. Remove the 'other' permissions to mitigate this.
silkeh
force-pushed
the
update-app-permissions
branch
from
e44a970 to
4c88ca0
Compare
|
@poikilotherm Tests should be fixed now (though Travis has some issues). Thanks! |
|
@poikilotherm any idea why Travis is failing? |
|
I'm sorry - currently stuck in other stuff. Will look at this in the nearer future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the app configuration world readable may expose the content of
more sensitive environment variables. Remove the 'other' permissions
to mitigate this.