Skip to content

Commit

Permalink
using different fork of Parameters.jl to allow type override
Browse files Browse the repository at this point in the history
  • Loading branch information
pohlan committed Sep 20, 2021
1 parent 37bb287 commit 3764a22
Show file tree
Hide file tree
Showing 4 changed files with 971 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ docs/site/
# It records a fixed state of all packages used by the project. As such, it should not be
# committed for packages, but should be committed for applications that require a static
# environment.
Manifest.toml
# Manifest.toml
Loading

1 comment on commit 3764a22

@pohlan
Copy link
Owner Author

@pohlan pohlan commented on 3764a22 Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue was in redefining the function calc_m_t:

scaled_params = Para(p,
# Scalars (one global value)
g = g / g_,
ρw = ρw / ρ_,
ρi = ρw / ρ_ / r_ρ,
k = k / k_,
A = A / A_,
lr = lr / lr_,
hr = hr / h_,
ub = ub / ub_,
# Field parameters (defined on every grid point)
H = H ./ H_,
zb = zb ./ zb_,
calc_m_t = t -> calc_m_t(t) ./ m_,

Same issue as mauro3/Parameters.jl#127, solved in different fork: daviehh/Parameters.jl@6ff721b, the latter is now being used here.

Please sign in to comment.