Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reexport types from podium/client #493

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

wkillerud
Copy link
Contributor

For TypeScript users sometimes the podium/client package (used only for types) would be updated to a newer version than what was used in the latest podium/layout package. This would cause unexpected type incompatibilities. From this version on, export the types from podium/client so TypeScript users can remove the direct dependency on podium/client, ensuring the types are always in sync with podium/layout.

For TypeScript users sometimes the podium/client package (used only
for types) would be updated to a newer version than what was used
in the latest podium/layout package. This would cause unexpected
type incompatibilities. From this version on, export the types
from podium/client so TypeScript users can remove the direct
dependency on podium/client, ensuring the types are always in sync
with podium/layout.
Copy link

@leftieFriele leftieFriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ some lover for our TypeScript users is wonderful!

@wkillerud wkillerud merged commit 709011c into main Aug 12, 2024
7 checks passed
@wkillerud wkillerud deleted the reexport-client-types branch August 12, 2024 07:29
github-actions bot pushed a commit that referenced this pull request Aug 12, 2024
# [5.2.0](v5.1.20...v5.2.0) (2024-08-12)

### Features

* reexport types from podium/client ([#493](#493)) ([709011c](709011c))
Copy link

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants