multiple changes #21
Open
multiple changes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reasoning: allow users to provide directly a reference to function if it's to be executed for _any_ exceptions; in that case there's no value in them providing a dict
laur89
force-pushed
the
rework
branch
2 times, most recently
from
59c3974 to
3b00a4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main highlights:
a) allow defining
callback_by_exceptionas a{function,tuple,list};b) default
run_one_last_timeto True even if callback_by_exception is defined;c) add tests
d) validate
triesattribute is >= 1