Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(benchmark): rename the benchmarks from {revision} and PNPM to pacquet@{revision} and pnpm #156

Merged
merged 20 commits into from
Oct 21, 2023
Merged

feat(benchmark): rename the benchmarks from {revision} and PNPM to pacquet@{revision} and pnpm #156

merged 20 commits into from
Oct 21, 2023

Conversation

KSXGitHub
Copy link
Contributor

No description provided.

@KSXGitHub KSXGitHub requested review from zkochan and anonrig October 17, 2023 12:28
@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.02      8.9±2.22ms   487.4 KB/sec    1.00      8.8±4.41ms   495.3 KB/sec

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b57f30) 86.73% compared to head (20a78ad) 86.73%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   86.73%   86.73%           
=======================================
  Files          39       39           
  Lines        2540     2540           
=======================================
  Hits         2203     2203           
  Misses        337      337

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zkochan
zkochan reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@zkochan zkochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sub_dir doesn't sound like a better name than revision or revision_dir. Was it renamed because pnpm has a dir too? If I understand correctly the sub_dirs are where install runs. Maybe call it bench_dir, or test_dir, or action_dir?

tasks/integrated-benchmark/src/work_env.rs Outdated Show resolved Hide resolved
tasks/integrated-benchmark/src/work_env.rs Outdated Show resolved Hide resolved
tasks/integrated-benchmark/src/work_env.rs Outdated Show resolved Hide resolved
@KSXGitHub @zkochan
refactor: reuse revision_names
6bd2b7f 
Co-authored-by: Zoltan Kochan <[email protected]>
@KSXGitHub
Copy link
Contributor Author

Was it renamed because pnpm has a dir too?

Yes.

@KSXGitHub KSXGitHub force-pushed the benchmark-remove-reserved-keyword branch from 345299b to bc5ff73 Compare October 18, 2023 06:51
@KSXGitHub KSXGitHub force-pushed the benchmark-remove-reserved-keyword branch from f8c6cd8 to db3ae33 Compare October 18, 2023 07:06
@KSXGitHub KSXGitHub force-pushed the benchmark-remove-reserved-keyword branch from db3ae33 to fbfbb30 Compare October 18, 2023 07:08
@zkochan zkochan merged commit 46604f5 into main Oct 21, 2023
12 checks passed
@zkochan zkochan deleted the benchmark-remove-reserved-keyword branch October 21, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

@anonrig anonrig Awaiting requested review from anonrig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KSXGitHub @zkochan