Fixing the bugfix #1718 #1736
Merged
Fixing the bugfix #1718 #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmaillot
requested changes
Jan 15, 2024
Removed useless second default case that caused errors
|
@michaelmaillot Thank you for noticing that. I have updated the code. |
|
Sorry @IRRDC but as this is a hotfix release, target branch will be dev and not main (then we will cherry-pick your fix to master in order to release a patch verison). Would you mind resolving conflicts before the merge? |
|
@michaelmaillot should be resolved now. |
Restoring changes removed by merge.
|
@michaelmaillot Looks like the merge removed all my changes. I have restored them now. |
michaelmaillot
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix #1718 for bug #1717 was faulty and gets fixed with this.
What's in this Pull Request?
Removed the wrongly added reference to "results".