Added file handling in DynamicForm

[GuidoZam]

Q	A
Bug fix?	[ ]
New feature?	[x ]
New sample?	[ ]

What's in this Pull Request?

Added the possibility to choose the file to be uploaded to the document library.

[michaelmaillot]

Hi @GuidoZam,

Thanks for this enhancement!

After going through the code and the new props spec, I want to be sure of what you want to cover.

If I read you PR comment, you want to provide a feature that allows to upload a file to a document library.

But if I have a look at the enableFileSelection prop definition here, it says that you can add a file to a list item.

I tried with both approaches and it seems that it's not working with the list item context.

Here's what I suggest:

• If you want to only cover document libraries, it would be better to clarify it in the prop definition
  • In that case, maybe adding a couple of checks in order to display the file selection button based on the BaseTemplate property for example
• If you want to cover also lists, it has to be covered in the code
  • You can adapt the queries to do (add / update list item + add list attachment) from the BaseTemplate property also

In all the cases, can you upade the control's documentation page to reflect the enhancement? You could add a screen / video that covers this new feature if you want to 🙂

[GuidoZam]

Thanks @michaelmaillot for the reviews and the feedbacks.
I want to cover the case of adding the file when creating a new list item inside a document library, I'll try to enhance the prop description and to also add some checks.

[AJIXuMuK]

@GuidoZam - seems like I still can enable file upload for standard lists (not doc libs)

[GuidoZam]

@AJIXuMuK I've added a check using the contentTypeId property of the dynamicForm control, that should be enough to restrict the usage only to document libraries.

[michaelmaillot]

Hi @GuidoZam, thanks for the update!

I've made some comments as a review.

Sorry to insist but could you please update the DynamicForm's documentation page in order to reflect the new props added in this PR? Feel free to insert screens / gifs or not.

[GuidoZam]

Hi @michaelmaillot, sorry for the delay, I'll have a look at your reviews and update the documentation in the next days.

[GuidoZam]

Hi @michaelmaillot I've made some improvements, can you please check if now it's all good?

[michaelmaillot]

Hi @GuidoZam,

Sounds good to me! Can you just resolve the remaining conflict before I merge your PR please?

Edit: I just saw that there was a tiny update to do on the DynamicForm doc page, which I've pointed out.

[GuidoZam]

Hi @michaelmaillot, I've resolved the remaining conflict.
For the update regarding the doc page I cannot see anything, am I missing something?

[michaelmaillot]

I've mentioned you in the review comment here

[GuidoZam]

@michaelmaillot sorry but I can't see any comment there, if I click on the link you inserted it just select the row 62 of the DynamicForm.md file.

[michaelmaillot]

@michaelmaillot sorry but I can't see any comment there, if I click on the link you inserted it just select the row 62 of the DynamicForm.md file.

Nevermind, forgot to submit my review.........🤦‍♂️

Sorry about that.

[GuidoZam]

@michaelmaillot sorry but I can't see any comment there, if I click on the link you inserted it just select the row 62 of the DynamicForm.md file.

Nevermind, forgot to submit my review.........🤦‍♂️

Sorry about that.

No problem, I've resolved the change request.

[michaelmaillot]

PR merged, thank you for your patience and your work @GuidoZam!