Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rds/kjw/rule 23 6 #880

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Rds/kjw/rule 23 6 #880

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43cff33
Update Rule23-6.md
KarenWGard Jan 1, 2023
5f0280a
Update Rule23-6.md
KarenWGard Jan 1, 2023
184f4f7
Update Rule23-6.md
KarenWGard Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions docs/section23/Rule23-6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

1. get_baseline_system_types()
2. baseline_system_type_compare()
3. get_dict_of_zones_and_terminal_units_served_by_hvac_sys()
4. baseline_system_type_compare()


**Applicability Checks:**
Expand All @@ -37,19 +39,17 @@
- add the hvac_ids for this system type to the list of eligible_systems: `eligible_systems += baseline_hvac_system_dict[baseline_system_type]`


- For each zone in B_RMR: `for zone_b in B_RMI...zones:`
- get a dictionary of hvac systems, their zones and terminal units using the function get_dict_of_zones_and_terminal_units_served_by_hvac_sys : `dict_of_zones_and_terminal_units_served_by_hvac_sys = get_dict_of_zones_and_terminal_units_served_by_hvac_sys(B_RMI)`
- loop through the hvac systems in the dictionary: `for hvac_b_id in dict_of_zones_and_terminal_units_served_by_hvac_sys:`
- Check if HVAC system is type 6, 8, 8a, 6b, 8b: `if hvac_b_id in eligible_systems:`
- we do the rule check for each terminal: `for terminal_b_id in dict_of_zones_and_terminal_units_served_by_hvac_sys[hvac_b_id]["Terminal_Unit_List"]:`
- get the terminal unit associated with the id: `terminal_b = match_data_element(B_RMI,Terminal,terminal_b_id)`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may misunderstood, if the applicability check already filtered out the applicable HVAC systems, why do we need to check for eligibility again at line 44?
We can do:
dict_of_zones_and_terminal_units_served_by_hvac_sys[hvac_b_id]?

- For each terminal in zone: `for terminal_b in zone_b.terminals:`
**Rule Assertion:**

- Get HVAC system serving terminal: `hvac_b = terminal_b.served_by_heating_ventilating_air_conditioning_system`

- Check if HVAC system is type 6, 8, 8a, 6b, 8b: `if hvac_b.id in eligible_systems:`
- Case 1: For each terminal that is served by HVAC system that is Type-6, 8, 8a, 6b, 8b, if fan in parallel VAV-powered box is sized for 50% of the peak design primary air (from the VAV air-handling unit) flow rate (CFM) and is modeled with 0.35W/cfm fan power: `if ( terminal_b.fan.design_airflow == terminal_b.primary_airflow * 0.5 ) AND ( terminal_b.fan.design_electric_power == 0.35 * terminal_b.fan.design_airflow ): PASS`

**Rule Assertion:**

- Case 1: For each terminal that is served by HVAC system that is Type-6, 8, 8a, 6b, 8b, if fan in parallel VAV-powered box is sized for 50% of the peak design primary air (from the VAV air-handling unit) flow rate (CFM) and is modeled with 0.35W/cfm fan power: `if ( terminal_b.fan.design_airflow == terminal_b.primary_airflow * 0.5 ) AND ( terminal_b.fan.design_electric_power == 0.35 * terminal_b.fan.design_airflow ): PASS`

- Case 2: Else: `else: FAIL`
- Case 2: Else: `else: FAIL`

**Notes:**
1. Updated the Rule ID from 23-5 to 23-6 on 11/28/2022
Expand Down