-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Rule23-17.md #1570
Open
KarenWGard
wants to merge
3
commits into
develop
Choose a base branch
from
RDS/KJW/Rule_23-17
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create Rule23-17.md #1570
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
|
||
# Airside System - Rule 23-17 | ||
|
||
**Schema Version:** 0.0.34 | ||
**Mandatory Rule:** TRUE | ||
**Rule ID:** 23-1 | ||
**Rule Description:** System 2 and 4 - Electric air-source heat pumps shall shall be modeled to continue to operate while auxiliary heat is energized. | ||
**Rule Assertion:** B-RMR = expected value | ||
**Appendix G Section:** Section 23 Air-side | ||
**90.1 Section Reference:** G3.1.3.1 Heat Pumps (Systems 2 and 4) | ||
**Data Lookup:** None | ||
**Evaluation Context:** HVAC System | ||
|
||
**Applicability Checks:** | ||
|
||
1. B-RMR is modeled with at least one air-side system that is Type-2, or 4 | ||
|
||
**Function Calls:** | ||
|
||
1. get_baseline_system_types() | ||
2. baseline_system_type_compare() | ||
3. get_component_by_id() | ||
|
||
**Applicability Checks:** | ||
- create a list of the target system types: `APPLICABLE_SYS_TYPES = [HVAC_SYS.SYS_2,HVAC_SYS.SYS_4]` | ||
- Get B-RMR system types: `baseline_system_types_dict = get_baseline_system_types(B-RMR)` | ||
|
||
- loop through the applicable system types: `for target_sys_type in APPLICABLE_SYS_TYPES:` | ||
- and loop through the baseline_system_types_dict to check the system types of the baseline systems: `for system_type in baseline_system_types_dict:` | ||
- do baseline_system_type_compare to determine whether the baseline_system_type is the applicable_system_type: `if((baseline_system_type_compare(system_type, target_sys_type, false)):` | ||
- the systems in the list: baseline_system_types_dict[system_type] are sys-2 or 4 - loop through the list of systems: `for hvac_system_id in baseline_system_types_dict[system_type]:` | ||
- `CONTINUE TO RULE LOGIC` | ||
- otherwise, rule not applicable: `else: RULE_NOT_APPLICABLE` | ||
|
||
**Rule Logic:** | ||
- get the hvac system from the hvac_system_id: `hvac_system = get_component_by_id(hvac_system_id)` | ||
- get the heating system: `heating_system = hvac_system.heating_system` | ||
- get the heatpump_low_shutoff_temperature = `heatpump_low_shutoff = heating_system.heatpump_low_shutoff_temperature` | ||
|
||
**Rule Assertion:** | ||
- Case 1: The heat pump low shutoff temperature is less than or equal to the minimum temperature a habitable place could reasonable be: `if heatpump_low_shutoff <= -56F: PASS` | ||
- Case 2: all other cases: FAIL: `else: FAIL` | ||
|
||
**Notes:** | ||
1. The minimum temperature is not finalized and is up for discussion. Must coordinate with the note provided in the schema element: HeatingSystem.heatpump_low_shutoff_temperature | ||
|
||
**[Back](../_toc.md)** |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Jason made it so -999 indicates that the heat pump continues to operate with a cut off. Suggest revising accordingly.