Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruletest JSON Excel Documentation #1261

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Conversation

jugonzal07
Copy link
Contributor

Added code to generate rule test documentation in the form of an Excel workbook.

gonz102 added 2 commits January 16, 2024 20:32
… sheet. Requires a new python package called "openpyxl"
@jugonzal07 jugonzal07 added documentation Improvements or additions to documentation rule_test labels Jan 17, 2024
Copy link
Collaborator

@yunjoonjung-PNNL yunjoonjung-PNNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Juan! I left a few optional comments. I'd appreciate it if you could review them before merging. Thanks!

Copy link
Collaborator

@weilixu weilixu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you Juan, I leave two comments.

@weilixu weilixu merged commit f0bee25 into develop Feb 22, 2024
1 of 2 checks passed
@weilixu weilixu deleted the RT/JG/ruletests_excel_documentation branch February 6, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rule_test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants