-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: changeable keybindings #203
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/racing-game/6P5gPxkJBjUBkuU37GbraVTuMNvH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this awesome feature! Great work so far, just some minor changes.
Sorry for this long delay, as you may heard, one idiot-president had started a war against our beloved neighbours - Ukraine (sad but true - I'm from russia 😞 ), so I had to leave my country urgently just not to support the government and wander a bit in search of new home. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
No worries, yes I heard ( even though I live under a rock ) I hope you are staying safe out there and 🤞 you find a new home soon! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! can you make the final change & resolve the merge conflict? and then we can merge it in! 🚀
Can you resolve the merge conflicts? |
@littlemyx Can you resolve the CI checks as well? |
@littlemyx it is still failing, can you make sure it is passing? |
done! sorry for this, first-time-contributing errors 😞 |
We are unable to merge this branch due to conflicts, can you rebase against the main branch? |
2a27585
to
ce13d32
Compare
Adding an ability to change keybindings
For #168