Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: changeable keybindings #203

Merged
merged 6 commits into from
Apr 15, 2022

Conversation

littlemyx
Copy link

@littlemyx littlemyx commented Feb 20, 2022

Adding an ability to change keybindings
For #168

@vercel
Copy link

vercel bot commented Feb 20, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/racing-game/6P5gPxkJBjUBkuU37GbraVTuMNvH
✅ Preview: https://racing-game-git-fork-littlemyx-changeable-keybindings-pmndrs.vercel.app

Copy link
Member

@njm222 njm222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this awesome feature! Great work so far, just some minor changes.

src/controls/Keyboard.ts Outdated Show resolved Hide resolved
src/controls/Keyboard.ts Outdated Show resolved Hide resolved
src/store.ts Outdated Show resolved Hide resolved
src/store.ts Show resolved Hide resolved
src/store.ts Show resolved Hide resolved
src/store.ts Outdated Show resolved Hide resolved
src/styles.css Outdated Show resolved Hide resolved
src/ui/Help.tsx Outdated Show resolved Hide resolved
src/ui/Help.tsx Outdated Show resolved Hide resolved
@littlemyx
Copy link
Author

Sorry for this long delay, as you may heard, one idiot-president had started a war against our beloved neighbours - Ukraine (sad but true - I'm from russia 😞 ), so I had to leave my country urgently just not to support the government and wander a bit in search of new home.

src/store.ts Outdated Show resolved Hide resolved
src/store.ts Outdated Show resolved Hide resolved
src/store.ts Outdated Show resolved Hide resolved
src/ui/Help.tsx Outdated Show resolved Hide resolved
Copy link
Member

@njm222 njm222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

No worries, yes I heard ( even though I live under a rock ) I hope you are staying safe out there and 🤞 you find a new home soon! :)

Copy link
Member

@njm222 njm222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! can you make the final change & resolve the merge conflict? and then we can merge it in! 🚀

src/ui/Keys.tsx Outdated Show resolved Hide resolved
src/ui/Keys.tsx Outdated Show resolved Hide resolved
@bjornstar
Copy link
Member

Can you resolve the merge conflicts?

@njm222
Copy link
Member

njm222 commented Apr 12, 2022

@littlemyx Can you resolve the CI checks as well?

@njm222
Copy link
Member

njm222 commented Apr 12, 2022

@littlemyx it is still failing, can you make sure it is passing?

@littlemyx
Copy link
Author

@littlemyx it is still failing, can you make sure it is passing?

done! sorry for this, first-time-contributing errors 😞

@bjornstar
Copy link
Member

We are unable to merge this branch due to conflicts, can you rebase against the main branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants