Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convergence of MPSA for the Sneddon problem #1283

Closed
wants to merge 4 commits into from

Conversation

isakhammer
Copy link
Contributor

Proposed changes

This pull request includes a reimplementation of Sneddon's analytical solution as outlined in https://doi.org/10.1007/s10596-020-10002-5.

Sneddon's solution provides an analytical method to compute the normal jump displacement for a pressurized fracture under linear elasticity conditions. The boundary element method is then integrated to compute semi-analytical boundary values, which are subsequently used to verify the MPSA numerical method for an open fracture. This process serves to validate the accuracy and convergence of the proposed numerical method, making it well-suited as a test case.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.

  • Static typing is included in the update.

  • This PR does not duplicate existing functionality.

  • The update is covered by the test suite (including tests added in the PR).

  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.
    What types of changes does this PR introduce to PorePy?
    Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).

  • Bugfix (non-breaking change which fixes an issue).

  • New feature (non-breaking change which adds functionality).

  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

  • Testing (contribution related to testing of existing or new functionality).

  • Documentation (contribution related to adding, improving, or fixing documentation).

  • Maintenance (e.g., improve logic and performance, remove obsolete code).

  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

@isakhammer isakhammer marked this pull request as ready for review December 9, 2024 12:16
@IvarStefansson
Copy link
Contributor

This code does not seem to be quite ready for a PR. For the BEM code, documentation and formatting must be updated to current PorePy. For the error computation and convergence testing functionality, we should use the existing framework (see e.g. mandel_biot.py and convergence_analysis.py

@isakhammer isakhammer mentioned this pull request Jan 24, 2025
12 tasks
@isakhammer isakhammer closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants