Skip to content

Commit

Permalink
Some small bugfixes and updated readme (brefphp#7)
Browse files Browse the repository at this point in the history
* Small bugfixes and cleanup

* Updated readme with new extensions

* cs

* Typo
  • Loading branch information
Nyholm authored Dec 30, 2019
1 parent c8b6b84 commit 2796b0d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ php_versions = 72 73 74

docker-images:
PWD=pwd
set -e; \
for dir in layers/*; do \
for php_version in $(php_versions); do \
echo "###############################################"; \
Expand All @@ -21,6 +22,7 @@ layers: docker-images
PWD=pwd
rm -rf export/layer-*.zip || true
mkdir export/tmp
set -e; \
for dir in layers/*; do \
for php_version in $(php_versions); do \
echo "###############################################"; \
Expand Down
5 changes: 5 additions & 0 deletions Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,13 @@ extension=/opt/bref-extra/amqp.so
| ---- | ----------------------------| -------------- |
| AMQP | `${bref:extra.amqp-php-74}` | `extension=/opt/bref-extra/amqp.so` |
| Blackfire | `${bref:extra.blackfire-php-74}` | `extension=/opt/bref-extra/blackfire.so` |
| GMP | `${bref:extra.gmp-php-74}` | `extension=/opt/bref-extra/gmp.so` |
| Memcache | `${bref:extra.memcached-php-74}` | `extension=/opt/bref-extra/memcache.so` |
| Memcached | `${bref:extra.memcached-php-74}` | `extension=/opt/bref-extra/memcached.so` |
| Xdebug | `${bref:extra.xdebug-php-74}` | `zend_extension=/opt/bref-extra/xdebug.so` |

Note that the "Memcached" layer provides both extension for [Memcache](https://pecl.php.net/package/memcache) and [Memcached](https://pecl.php.net/package/memcached).

## Deploy new versions

```
Expand Down
8 changes: 5 additions & 3 deletions src/Aws/LayerProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Bref\Extra\Aws;

use Aws\Lambda\LambdaClient;
use function GuzzleHttp\Promise\unwrap;

/**
* Fetches layers and details from AWS
Expand All @@ -25,7 +26,6 @@ public function __construct(array $layerNames, string $awsId)
$this->layerNames = $layerNames;
}


public function listLayers(string $selectedRegion): array
{
$lambda = new LambdaClient([
Expand All @@ -49,8 +49,10 @@ public function listLayers(string $selectedRegion): array
$layers = [];
foreach ($results as $layerName => $result) {
$versions = $result['LayerVersions'];
$latestVersion = end($versions);
$layers[$layerName] = $latestVersion['Version'];
if (! empty($versions)) {
$latestVersion = end($versions);
$layers[$layerName] = $latestVersion['Version'];
}
}

return $layers;
Expand Down

0 comments on commit 2796b0d

Please sign in to comment.