Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infrastructure stack CRD a bit #982

Conversation

michaeljguarino
Copy link
Member

need to use our defined job spec not the main k8s one.

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

@michaeljguarino michaeljguarino requested a review from a team May 25, 2024 22:35
Copy link

linear bot commented May 25, 2024

@michaeljguarino michaeljguarino added the enhancement New feature or request label May 25, 2024
need to use our defined job spec not the main k8s one.
@michaeljguarino michaeljguarino force-pushed the mjg/eng-2113-dont-use-kubernetes-batchv1jobspec-for-infrastructure-stack branch from f5c9c47 to 7ed79b3 Compare May 26, 2024 20:52
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 7ed79b3):

https://pluralsh-console--pr982-mjg-eng-2113-dont-us-f4hbp52l.web.app

(expires Sun, 02 Jun 2024 20:55:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@michaeljguarino michaeljguarino merged commit 3dc772b into master May 26, 2024
16 checks passed
@michaeljguarino michaeljguarino deleted the mjg/eng-2113-dont-use-kubernetes-batchv1jobspec-for-infrastructure-stack branch May 26, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant