added indicator to service sync button #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsladerman
added
enhancement
|
Visit the preview URL for this PR (updated for commit cc2168e): https://pluralsh-console--pr907-jake-eng-2034-add-in-oc8eq5r7.web.app (expires Thu, 09 May 2024 03:20:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce |
jsladerman
force-pushed
the
jake/eng-2034-add-indicator-for-last-sync-of-git-repo-on-sync-button
branch
from
6981ba8 to
3c46bdf
Compare
michaeljguarino
requested changes
May 2, 2024
assets/src/components/apps/Apps.tsx
Outdated
| @@ -158,7 +158,7 @@ export default function Apps() { | |||
| const navigate = useNavigate() | |||
|
|
|||
| useEffect(() => { | |||
| if (configuration?.byok) navigate('/cd/clusters') | |||
| if (configuration?.byok) navigate('/home') | |||
There was a problem hiding this comment.
should revert this for now
jsladerman
force-pushed
the
jake/eng-2034-add-indicator-for-last-sync-of-git-repo-on-sync-button
branch
from
3c46bdf to
cc2168e
Compare
ah looks like I was still on that branch when I created this one. took the home screen commit out should be good now |
michaeljguarino
approved these changes
May 2, 2024
michaeljguarino
deleted the
jake/eng-2034-add-indicator-for-last-sync-of-git-repo-on-sync-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a line to the tooltip indicating last time a service's git repo was pulled
Sync button also disables with a countdown if it's been < 15 seconds since last pull