Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update tooling pipeline and vendor most critical tool binaries #1945

Merged
merged 10 commits into from
Mar 3, 2025

Conversation

floreks
Copy link
Member

@floreks floreks commented Feb 28, 2025

  • Tools will now be properly installed based on the version defined in tools module go.mod file. Previously go install had only a dep name passed. It resulted in the latest version of dep being installed.
  • Tools will now be installed in the <ROOT_DIR>/binaries directory. This is to avoid discrepancies between our local tool versions and inconsistencies in generated code. This is especially important for tools like kubebuilder and gqlgenc.
  • Go modules makefile targets that rely on vendored tools will now always install specific tool before running the actual target. This is to avoid outdated tools usage that are not in sync with the tools go.mod file. go install will check if binary is already in the output dir to avoid redownloads.
  • Updated GH actions to not use explicit tools download step. Every target should download required tools via target dependency on internal --tool target.

Note: Pipeline could be further extended to cover other tools used by our scripts like: helm, kubectl, etc.

Test Plan

Locally

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

@floreks floreks self-assigned this Feb 28, 2025
@floreks floreks added the bug-fix This pull request fixes a bug label Feb 28, 2025
@floreks floreks merged commit 8aa86dd into master Mar 3, 2025
22 checks passed
@floreks floreks deleted the fix/tools branch March 3, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants