new log filter ui #1941
Merged
new log filter ui #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsladerman
added
enhancement
jsladerman
force-pushed
the
jake/prod-3243-logs-filter-improvements
branch
from
3c60ebb to
128bd8d
Compare
jsladerman
force-pushed
the
jake/prod-3243-logs-filter-improvements
branch
from
1a2c29c to
a78c959
Compare
michaeljguarino
approved these changes
Feb 26, 2025
|
So I actually find the date input ux here quite confusing, i think it would be a lot clearer if it just showed the full current time by default and made it immediately editable. if there's a concern about getting the "now" time right, just have it constantly tick until its edited manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incorporates new SegmentedInput component (pluralsh/design-system#687) to handle date/time filters
