Support openai embeddings endpoints in ai proxy #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The router here still doesn't really make sense to me. Does it not direct /v1/embeddings to bedrock if that's the underlying provider? And same for the chat requests. We shouldn't be exposing bedrock url paths, it should just be the standard openai url paths.
…ndpoints-in-ai-proxy
| @@ -153,7 +152,7 @@ func TestBedrockEmbeddingsProxy(t *testing.T) { | |||
| { | |||
| Name: "embeddings request should return correct openai response", | |||
| Method: "POST", | |||
| Endpoint: bedrock.EndpointEmbeddings, | |||
| Endpoint: "/v1/embeddings", | |||
There was a problem hiding this comment.
this needs to be on the same prefix as the other openai endpoints
There was a problem hiding this comment.
it's not?
console/go/ai-proxy/api/openai/openai.go
Line 18 in fb8f403
There was a problem hiding this comment.
the other endpoints exposed were /openai/v1/chat/completions. You can put it under both, but the openai path prefix is not a bad way to do it.
michaeljguarino
approved these changes
Feb 24, 2025
JohnBlackwell
deleted the
john/prod-3217-support-openai-embeddings-endpoints-in-ai-proxy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Checklist