enhancement: Console controller error handling improvements #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciaszczykm
commented
Jan 31, 2025
Comment on lines
+37
to
+48
| // handleRequeue allows avoiding rate limiting when some errors occur, | ||
| // i.e., when a resource is not created yet, or when it is waiting for an ID. | ||
| // | ||
| // If the result is set, then any potential error will be saved in a condition | ||
| // and ignored in the return to avoid rate limiting. | ||
| // | ||
| // It is important that at least one from a result or an error have to be non-nil. | ||
| func handleRequeue(result *ctrl.Result, err error, setCondition func(condition metav1.Condition)) (ctrl.Result, error) { | ||
| utils.MarkCondition(setCondition, v1alpha1.SynchronizedConditionType, metav1.ConditionFalse, | ||
| v1alpha1.SynchronizedConditionReasonError, defaultErrMessage(err, "")) | ||
| return lo.FromPtr(result), lo.Ternary(result != nil, nil, err) | ||
| } |
There was a problem hiding this comment.
Highlighting the function that handles requeue logic.
…nsole-controller-improvements
…nsole-controller-improvements
michaeljguarino
approved these changes
Feb 10, 2025
|
how much testing have we done here? |
floreks
approved these changes
Feb 10, 2025
maciaszczykm
deleted the
marcin/prod-3146-console-controller-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not everything yet, but waiting longer can cause conflicts. It will also be easier to use similar method in other changes once this gets merged.
Tested on dev cluster with sample custom resources.