fix: Fix service reconciler requeue logic #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciaszczykm
force-pushed
the
marcin/prod-3138-changing-the-configurationref-of-a-service-doesnt-properly
branch
2 times, most recently
from
d3fab9a to
ef2f6ab
Compare
maciaszczykm
force-pushed
the
marcin/prod-3138-changing-the-configurationref-of-a-service-doesnt-properly
branch
from
ef2f6ab to
645c5db
Compare
michaeljguarino
approved these changes
Jan 28, 2025
maciaszczykm
deleted the
marcin/prod-3138-changing-the-configurationref-of-a-service-doesnt-properly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the service reconciler to requeue if error occurs when searching for referenced resources (or theirs IDs). Errors will be set in the condition but not returned as it results in rate limiting being applied.
Tested with controller running locally on kind cluster.