Make clusterRefs mutable

pluralsh · Jan 29, 2025 · 712a1a1 · 712a1a1
1 parent 6dff0d3
commit 712a1a1
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 12 deletions.
diff --git a/charts/controller/crds/deployments.plural.sh_servicedeployments.yaml b/charts/controller/crds/deployments.plural.sh_servicedeployments.yaml
@@ -124,9 +124,6 @@ spec:
                     type: string
                 type: object
                 x-kubernetes-map-type: atomic
-                x-kubernetes-validations:
-                - message: Cluster is immutable
-                  rule: self == oldSelf
               configuration:
                 additionalProperties:
                   type: string

diff --git a/go/controller/api/v1alpha1/servicedeployment_types.go b/go/controller/api/v1alpha1/servicedeployment_types.go
@@ -3,12 +3,13 @@ package v1alpha1
 import (
 	"encoding/json"
 
-	console "github.com/pluralsh/console/go/client"
 	"github.com/samber/lo"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
+
+	console "github.com/pluralsh/console/go/client"
 )
 
 func init() {
@@ -159,7 +160,6 @@ type ServiceSpec struct {
 	// +kubebuilder:validation:Optional
 	RepositoryRef *corev1.ObjectReference `json:"repositoryRef"`
 	// +kubebuilder:validation:Required
-	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Cluster is immutable"
 	ClusterRef corev1.ObjectReference `json:"clusterRef"`
 	// ConfigurationRef is a secret reference which should contain service configuration.
 	// +kubebuilder:validation:Optional

diff --git a/go/controller/config/crd/bases/deployments.plural.sh_servicedeployments.yaml b/go/controller/config/crd/bases/deployments.plural.sh_servicedeployments.yaml
@@ -124,9 +124,6 @@ spec:
                     type: string
                 type: object
                 x-kubernetes-map-type: atomic
-                x-kubernetes-validations:
-                - message: Cluster is immutable
-                  rule: self == oldSelf
               configuration:
                 additionalProperties:
                   type: string

diff --git a/go/controller/internal/test/mocks/ConsoleClient_mock.go b/go/controller/internal/test/mocks/ConsoleClient_mock.go
diff --git a/plural/helm/console/crds/deployments.plural.sh_servicedeployments.yaml b/plural/helm/console/crds/deployments.plural.sh_servicedeployments.yaml
@@ -124,9 +124,6 @@ spec:
                     type: string
                 type: object
                 x-kubernetes-map-type: atomic
-                x-kubernetes-validations:
-                - message: Cluster is immutable
-                  rule: self == oldSelf
               configuration:
                 additionalProperties:
                   type: string