Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assign tags from rules #225

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

RomainLvr
Copy link
Contributor

@RomainLvr RomainLvr commented Jan 21, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !35539
  • Here is a brief description of what this PR does

Adding a tag using the rules engine is impossible when triggered with a self-service profile. This PR identifies tag addition by the rule engine and ignores the tag addition right of the triggering profile.

@RomainLvr RomainLvr requested review from stonebuzz and Rom1-B January 21, 2025 12:50
@RomainLvr RomainLvr self-assigned this Jan 21, 2025
inc/tagitem.class.php Outdated Show resolved Hide resolved
inc/tagitem.class.php Outdated Show resolved Hide resolved
@RomainLvr RomainLvr requested a review from stonebuzz January 21, 2025 13:21
inc/tagitem.class.php Outdated Show resolved Hide resolved
@stonebuzz
Copy link
Contributor

  1. Test of the Rule Applying a TAG (Self-Service User)

    • Create a rule that applies a specific TAG to a ticket.
    • Simulate the creation of a ticket by a 'self-service' user.
    • Verify that the TAG defined by the rule is correctly applied to the ticket.
  2. Test of the Rule Applying a TAG (Technician User)

    • Log in with a technician account.
    • Simulate the creation of a ticket.
    • Verify that the TAG defined by the rule is correctly applied to the ticket.
  3. Test of Manual TAG + Rule-Based TAG

    • Log in with a technician account.
    • Simulate the creation of a ticket and manually add a specific TAG.
    • Verify that both the rule-based TAG and the manually added TAG are correctly applied to the ticket.

@RomainLvr RomainLvr requested a review from stonebuzz January 22, 2025 13:44
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG

inc/tagitem.class.php Outdated Show resolved Hide resolved
@stonebuzz stonebuzz self-requested a review January 23, 2025 08:51
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Stanislas <[email protected]>
@stonebuzz stonebuzz self-requested a review January 23, 2025 09:07
@Rom1-B Rom1-B merged commit bf786ff into pluginsGLPI:main Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants