Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chart-studio and plotly-geo to separate repositories #4972

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

emilykl
Copy link
Contributor

@emilykl emilykl commented Jan 15, 2025

This PR removes the entire contents of the chart-studio and plotly-geo packages from this repository.

These packages, and their respective Git histories, have been moved to their own individual repositories:

Changes in this PR:

  • Delete directories packages/python/chart-studio and packages/python/plotly-geo
  • Update CI in config.yml:
    • Install chart-studio from PyPI rather than installing from local directory
    • Remove chart-studio testing workflow (Note: Was not being run anyway)
  • Update contributing.md and release.md to remove references to chart-studio and plotly-geo
    • The text has been deleted here but added to the individual repos as needed

Rationale

Moves us to a '1 repo = 1 package on PyPI' structure, and makes it possible to drastically simplify the directory structure in the Plotly.py repository.

@emilykl emilykl marked this pull request as ready for review January 29, 2025 03:36
@emilykl emilykl changed the title [Draft] Move chart-studio and plotly-geo Move chart-studio and plotly-geo to separate repositories Jan 29, 2025
release.md Outdated
@@ -2,7 +2,10 @@
# How to release plotly packages

There are 3 Python packages (`plotly`, `plotly-geo` and `chart-studio`) which need to be
published to PyPI and conda. In addition, there are various changelogs, github releases and forum announcements to do :)
published to PyPI and conda. The `plotly` package is located in this repository, while `plotly-geo` and `chart-studio` are located in their own separate repositories under those names.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like you could just remove this entire paragraph?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is, this kind of implies that you'd want to also publish those when you publish plotly.py, which is pretty unlikely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll change the wording here.

Copy link
Collaborator

@marthacryan marthacryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! LGTM

@emilykl emilykl merged commit 9910078 into master Jan 30, 2025
5 checks passed
@emilykl emilykl deleted the move-chart-studio-and-plotly-geo branch January 30, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants