Better support for running Plone on PaaS providers such as Heroku #39
Conversation
|
This PR is required to fix plone/heroku-buildpack-plone#25. |
| values.append(var) | ||
| env_vars = zip(keys, values) | ||
| cgi_environment_vars = '\n'.join(["%s %s" % (env_var[0], env_var[1]) | ||
| for env_var in env_vars]) |
There was a problem hiding this comment.
It looks like this processing could easily be factored into a function to avoid duplicating code between environment_vars and cgi_environment_vars.
|
@davisagli: I intentionally left out things as I was not sure if the PR should be against a 4.x branch, or rather against master and then I possibly do another PR for backporting? If I'm looking correctly, travis is broken on 4.x branch, so that made me question things. |
|
@zupo depends which release series of Plone you are targeting. The 4.x branch is used by Plone 5.1 and master is used by Plone 5.2 (with Zope 4). I don't think it matters whether you make a PR to master and then backport, or to 4.x and then forward-port. I just opened #40 to fix the travis build on the 4.x branch. |
Some containerized PaaS providers run the build process in a different location than where they run the end product, i.e. the app server. For example, when I run buildout on Heroku, the resulting zope.conf file contains a line like so: ``` %define INSTANCEHOME /tmp/build_857f615d508f92191ca58c6947e2def8/parts/instance ``` This path does not exist in the production environment, as there the instance home is at `/app/parts/instance`. This commit allows me to set the instance home as an option inside the plone.recipe.zope2instance section in my buildout.cfg file: ``` [instance] recipe = plone.recipe.zope2instance instance-home = /app/parts/instance client-home = /app/var/instance ```
This is needed so that we are able to tell Plone to run in HTTPS mode on PaaS providers such as Heroku. Currently, it is achieved with the following Ugly Hack™: https://github.com/plone/heroku-buildpack-plone/blob/f22284cef9d790970d309c8c4591441d24b961ec/configure_zopeconf.py#L22
zupo
changed the title
|
@davisagli: added documentation, tests; removed code duplication. Please review. |
Some containerized PaaS providers run the build process in a different location than where they run the end product, i.e. the app server.
For example, when I run buildout on Heroku, the resulting zope.conf file contains a line like so:
This path does not exist in the production environment, as there, the instance home is at
/app/parts/instance.This commit allows me to set the instance home as an option inside the plone.recipe.zope2instance section in my buildout.cfg file: