DOC: Update RTD config

DOC: Update version parsing in conf.py

TST: Remove build_docs from CI

TST: Fix bandit YAML

TST: Move flake8 settings to setup.cfg

MNT: Remove unused imports in app.py

.bandit.yaml

@@ -1,5 +1,5 @@
 exclude_dirs:
   - jdaviz/tests
 
-skips: ['B101' # skip warning about asserts - they are used as behavior checks not as code tools
-       ]
+# skip warning about asserts - they are used as behavior checks not as code tools
+skips: ['B101']

.github/workflows/ci_workflows.yml

@@ -55,12 +55,6 @@ jobs:
             toxenv: py38-test
             allow_failure: false
 
-          - name: Documentation build
-            os: ubuntu-latest
-            python: 3.8
-            toxenv: build_docs
-            allow_failure: false
-
     steps:
     - name: Checkout code
       uses: actions/checkout@v2

.readthedocs.yml

@@ -3,13 +3,18 @@ version: 2
 build:
   image: latest
 
+sphinx:
+  builder: html
+  configuration: docs/conf.py
+  fail_on_warning: true
+
 python:
-  version: 3.7
+  version: 3.8
+  system_packages: true
   install:
     - method: pip
       path: .
       extra_requirements:
         - docs
-        - all
 
 formats: []

docs/conf.py

@@ -28,7 +28,7 @@
 import os
 import sys
 import datetime
-from importlib import import_module
+from pkg_resources import get_distribution
 
 try:
     from sphinx_astropy.conf.v1 import *  # noqa
@@ -40,8 +40,8 @@
 from configparser import ConfigParser
 conf = ConfigParser()
 
-conf.read([os.path.join(os.path.dirname(__file__), '..', 'setup.cfg')])
-setup_cfg = dict(conf.items('metadata'))
+conf.read(os.path.join(os.pardir, 'setup.cfg'))
+setup_cfg = conf['metadata']
 
 # -- General configuration ----------------------------------------------------
 
@@ -70,20 +70,18 @@
 project = setup_cfg['name']
 author = setup_cfg['author']
 copyright = '{0}, {1}'.format(
-    datetime.datetime.now().year, setup_cfg['author'])
+    datetime.datetime.now().year, author)
 
 # The version info for the project you're documenting, acts as replacement for
 # |version| and |release|, also used in various other places throughout the
 # built documents.
 
-import_module(setup_cfg['name'])
-package = sys.modules[setup_cfg['name']]
+package = get_distribution(project)
 
-# The short X.Y version.
-version = package.__version__.split('-', 1)[0]
 # The full version, including alpha/beta/rc tags.
-release = package.__version__
-
+release = package.version
+# The short X.Y version.
+version = '.'.join(release.split('.')[:2])
 
 # -- Options for HTML output --------------------------------------------------
 
@@ -104,10 +102,8 @@
 # name of a builtin theme or the name of a custom theme in html_theme_path.
 #html_theme = None
 
-
 html_theme = "sphinx_rtd_theme"
 
-
 # Custom sidebar templates, maps document names to template names.
 #html_sidebars = {}
 

jdaviz/app.py

@@ -1,16 +1,14 @@
 import logging
 import os
 import pathlib
+import pkg_resources
 import re
 import uuid
 from inspect import isclass
 
 import ipywidgets as w
-import numpy as np
-from astropy import units as u
-import pkg_resources
+
 from astropy.nddata import CCDData
-from spectral_cube import SpectralCube
 from echo import CallbackProperty, DictCallbackProperty, ListCallbackProperty
 from ipygoldenlayout import GoldenLayout
 from ipysplitpanes import SplitPanes
@@ -20,7 +18,6 @@
 
 from glue.config import data_translator
 from glue.core import BaseData, HubListener, Data, DataCollection
-from glue.core.autolinking import find_possible_links
 from glue.core.link_helpers import LinkSame
 from glue.core.message import (DataCollectionAddMessage,
                                DataCollectionDeleteMessage)
@@ -32,13 +29,12 @@
 
 from .core.config import read_configuration, get_configuration
 from .core.events import (LoadDataMessage, NewViewerMessage, AddDataMessage,
-                          SnackbarMessage, RemoveDataMessage, ConfigurationLoadedMessage, AddDataToViewerMessage, RemoveDataFromViewerMessage)
+                          SnackbarMessage, RemoveDataMessage,
+                          AddDataToViewerMessage, RemoveDataFromViewerMessage)
 from .core.registries import (tool_registry, tray_registry, viewer_registry,
                               data_parser_registry)
 from .utils import load_template
 
-#from .configs.mosviz.plugins.viewers import MOSVizProfile2DView
-
 __all__ = ['Application']
 
 SplitPanes()

setup.cfg

@@ -68,6 +68,10 @@ doctest_plus = enabled
 text_file_format = rst
 addopts = --doctest-rst
 
+[flake8]
+max-line-length = 100
+select = E101,W191,W291,W292,W293,W391,E111,E112,E113,E502,E722,E901,E902
+
 [coverage:run]
 omit =
     jdaviz/_astropy_init*

tox.ini

@@ -93,7 +93,7 @@ skip_install = true
 changedir = .
 description = check code style, e.g. with flake8
 deps = flake8
-commands = flake8 jdaviz --count --max-line-length=100 --select=E101,W191,W291,W292,W293,W391,E111,E112,E113,E502,E722,E901,E902
+commands = flake8 jdaviz --count
 
 [testenv:securityaudit]
 skip_install = true