Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates action versions, change how notebooks are tested #257

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

billbrod
Copy link
Collaborator

This does two things:

  • Updates action versions to get rid of the warning during github actions
  • Changes how notebooks are tested: we were previously parallelizing across all of them, which I think was actually costing us time (and making it output to navigate), so now we run them all in one action.

I was spending a lot of time on overhead. this removes get_notebook,
which also requires changing the all_tutorials_in_docs action
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.76%. Comparing base (1ac604b) to head (3cc0755).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files          35       35           
  Lines        3325     3325           
=======================================
  Hits         2885     2885           
  Misses        440      440           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@billbrod
Copy link
Collaborator Author

billbrod commented Feb 23, 2024

Turns out that this now looks like it will 22 to 28 minutes for the notebooks, whereas before, if things ran successfully, they would take ~20 minutes total. I think the small increase in time is worth it, given that our previous setup would occasionally just hang during one of the notebooks, and how difficult it was to navigate the output.

@billbrod billbrod merged commit 20a9a43 into main Feb 23, 2024
16 checks passed
@billbrod billbrod deleted the notebook_tests branch February 23, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant