avoid skipping mg-aggregate-results on failed MG test jobs

plebhash · Jul 17, 2024 · c8a9ce5 · c8a9ce5
1 parent 243e625
commit c8a9ce5
Showing 1 changed file with 49 additions and 21 deletions.
diff --git a/.github/workflows/mg.yaml b/.github/workflows/mg.yaml
@@ -162,24 +162,52 @@ jobs:
   mg-aggregate-results:
     name: "Aggregate MG Test Results"
     runs-on: ubuntu-latest
-    needs:
-      - bad-pool-config-test
-      - interop-jd-translator
-      - interop-proxy-with-multi-ups
-      - interop-proxy-with-multi-ups-extended
-      - jds-do-not-fail-on-wrong-tsdatasucc
-      - jds-do-not-panic-if-jdc-close-connection
-      - jds-do-not-stackoverflow-when-no-token
-      - pool-sri-test-1-standard
-      - pool-sri-test-close-channel
-      - pool-sri-test-extended_0
-      - pool-sri-test-extended_1
-      - pool-sri-test-reject-auth
-      - standard-coverage
-      - sv1-test
-      - translation-proxy-broke-pool
-      - translation-proxy
-      - translation-proxy-old-share
-    steps:
-      - name: Aggregate MG Test Results
-        run: echo "All MG tests completed successfully"
+    if: always()
+    needs: [
+      bad-pool-config-test,
+      interop-jd-translator,
+      interop-proxy-with-multi-ups,
+      interop-proxy-with-multi-ups-extended,
+      jds-do-not-fail-on-wrong-tsdatasucc,
+      jds-do-not-panic-if-jdc-close-connection,
+      jds-do-not-stackoverflow-when-no-token,
+      pool-sri-test-1-standard,
+      pool-sri-test-close-channel,
+      pool-sri-test-extended_0,
+      pool-sri-test-extended_1,
+      pool-sri-test-reject-auth,
+      standard-coverage,
+      sv1-test,
+      translation-proxy-broke-pool,
+      translation-proxy,
+      translation-proxy-old-share
+    ]
+    steps:
+      - name: Aggregate Results
+        run: |
+          JOBS=(
+            bad-pool-config-test
+            interop-jd-translator
+            interop-proxy-with-multi-ups
+            interop-proxy-with-multi-ups-extended
+            jds-do-not-fail-on-wrong-tsdatasucc
+            jds-do-not-panic-if-jdc-close-connection
+            jds-do-not-stackoverflow-when-no-token
+            pool-sri-test-1-standard
+            pool-sri-test-close-channel
+            pool-sri-test-extended_0
+            pool-sri-test-extended_1
+            pool-sri-test-reject-auth
+            standard-coverage
+            sv1-test
+            translation-proxy-broke-pool
+            translation-proxy
+            translation-proxy-old-share
+          )
+          for JOB in "${JOBS[@]}"; do
+            if [ "${{ needs[$JOB].result }}" != "success" ]; then
+              echo "Job $JOB failed."
+              exit 1
+            fi
+          done
+          echo "All MG tests completed successfully"