test(openapi): Cover oneOf schema from Verifiable Credential API with test #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that oneOf schemas been supported in `rororo` library. Fixes: #159
playpauseandstop
added
fix
With `openapi-core>=0.13.4,<0.13.7` it is impossible to support
following **valid** schema of,
```
Component:
type: "object"
oneOf:
- type: "string"
- type: "object"
...
```
as it does not negate global `type: "object"`, when resolves inner `type:
"string"`.
Cause of that mark test as XFAIL and hopefully the problem will gone
with migration to latest `openapi-core` 🤔
playpauseandstop
changed the title
playpauseandstop
added
test
Merged
badabump-release-bot bot
pushed a commit
that referenced
this pull request
May 29, 2023
Features: --------- - Ensure support of `environ-config@^23.2.0` (#360) Fixes: ------ - (**settings**) Ensure `setup_settings_from_environ` function works well (#361) - [#191] (**openapi**) Do not handle redirection errors (#362) Other: ------ - Monthly maintenance (Jan 2023) (#314) - Bump dev Python version to 3.11.2 (#326) - (**deps**) bump actions/checkout from 3.2.0 to 3.3.0 (#323) - (**deps-dev**) bump redis from 4.5.1 to 4.5.3 (#328) - (**deps-dev**) bump types-redis from 4.5.1.3 to 4.5.3.0 (#329) - (**deps**) bump requests from 2.28.2 to 2.31.0 (#353) - (**deps**) bump attrs from 22.2.0 to 23.1.0 (#349) - Bump dev Python version to 3.11.3 (#359) - (**deps**) bump actions/checkout from 3.3.0 to 3.5.2 (#352) - (**deps**) bump email-validator from 1.3.1 to 2.0.0.post2 (#346) - (**deps-dev**) bump mypy from 1.0.1 to 1.3.0 (#357) - (**deps-dev**) bump redis from 4.5.3 to 4.5.4 (#330) - (**deps-dev**) bump pytest from 7.2.1 to 7.3.1 (#347) - (**deps-dev**) bump pytest-asyncio from 0.20.3 to 0.21.0 (#336) - (**deps-dev**) bump types-pyyaml from 6.0.12.8 to 6.0.12.10 (#358) - (**deps-dev**) bump types-redis from 4.5.3.0 to 4.5.5.2 (#356) - (**deps-dev**) bump furo from 2022.12.7 to 2023.3.27 (#332) - (**deps-dev**) bump sphinx-copybutton from 0.5.1 to 0.5.2 (#344) - (**deps-dev**) bump sphinx-autodoc-typehints from 1.22 to 1.23.0 (#345) - [#159] (**openapi**) Cover oneOf schema from Verifiable Credential API with test (#363)
playpauseandstop
added a commit
that referenced
this pull request
May 29, 2023
The latest _rororo_ version allows to install library alongside latest version of `attrs` & `email-validator` and **require** latest `environ-config` version. On top of that `rororo==3.2.0` ensure that `web.HTTPRedirection` errors will not handled by error middleware and will result in proper redirects. Features: --------- - Ensure support of `environ-config@^23.2.0` (#360) Fixes: ------ - (**settings**) Ensure `setup_settings_from_environ` function works well (#361) - [#191] (**openapi**) Do not handle redirection errors (#362) Other: ------ - Monthly maintenance (Jan 2023) (#314) - Bump dev Python version to 3.11.2 (#326) - (**deps**) bump actions/checkout from 3.2.0 to 3.3.0 (#323) - (**deps-dev**) bump redis from 4.5.1 to 4.5.3 (#328) - (**deps-dev**) bump types-redis from 4.5.1.3 to 4.5.3.0 (#329) - (**deps**) bump requests from 2.28.2 to 2.31.0 (#353) - (**deps**) bump attrs from 22.2.0 to 23.1.0 (#349) - Bump dev Python version to 3.11.3 (#359) - (**deps**) bump actions/checkout from 3.3.0 to 3.5.2 (#352) - (**deps**) bump email-validator from 1.3.1 to 2.0.0.post2 (#346) - (**deps-dev**) bump mypy from 1.0.1 to 1.3.0 (#357) - (**deps-dev**) bump redis from 4.5.3 to 4.5.4 (#330) - (**deps-dev**) bump pytest from 7.2.1 to 7.3.1 (#347) - (**deps-dev**) bump pytest-asyncio from 0.20.3 to 0.21.0 (#336) - (**deps-dev**) bump types-pyyaml from 6.0.12.8 to 6.0.12.10 (#358) - (**deps-dev**) bump types-redis from 4.5.3.0 to 4.5.5.2 (#356) - (**deps-dev**) bump furo from 2022.12.7 to 2023.3.27 (#332) - (**deps-dev**) bump sphinx-copybutton from 0.5.1 to 0.5.2 (#344) - (**deps-dev**) bump sphinx-autodoc-typehints from 1.22 to 1.23.0 (#345) - [#159] (**openapi**) Cover oneOf schema from Verifiable Credential API with test (#363) Co-authored-by: playpauseandstop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
openapi-core>=0.13.4,<0.13.7it is impossible to support following valid schema of,as it does not negate global
type: "object", when resolves innertype: "string".Cause of that provide a test, but mark it as XFAIL, and hopefully the problem will gone with migration to latest
openapi-core🤔Issue: #159
Related: #149