Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Smoother Experience When Loading a Viewless Flow on iOS #570

Merged
merged 11 commits into from
Feb 5, 2025

Conversation

nancywu1
Copy link
Contributor

@nancywu1 nancywu1 commented Jan 8, 2025

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs
📦 Published PR as canary version: 0.10.2--canary.570.19246

Try this version out locally by upgrading relevant packages to 0.10.2--canary.570.19246

@nancywu1
Copy link
Contributor Author

/canary

@nancywu1
Copy link
Contributor Author

/canary

@nancywu1
Copy link
Contributor Author

\canary

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 94.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (cb3ea0c) to head (1259cd4).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
.../swiftui/Sources/ManagedPlayer/ManagedPlayer.swift 91.66% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files         331      331           
  Lines       19836    19900   +64     
  Branches     1949     1949           
=======================================
+ Hits        17805    17864   +59     
- Misses       2017     2022    +5     
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hborawski
hborawski previously approved these changes Feb 4, 2025
@nancywu1 nancywu1 marked this pull request as ready for review February 5, 2025 01:17
@nancywu1 nancywu1 merged commit 3830a1f into main Feb 5, 2025
11 checks passed
@nancywu1 nancywu1 deleted the ios-managed-player-loading-fix branch February 5, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants