Fix Binding Instantiation of Escaped Numerical Bindings #565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#533 fixed the parsing of bindings with escaped numbers however when the binding was being instantiated as a
BindingInstance
object leading zeroes were still being removed. This adds in the same logic to the BindingInstance class to ensure that throughout the lifecycle of a binding it stays appropriately repented.Benchmark Results
Main
Branch
There are also some minor fixes included in this:
Change Type (required)
Indicate the type of change your pull request is:
patch
minor
major
N/A
Does your PR have any documentation updates?
Release Notes
Fixed instantiation of
BindingInstance
s with escaped numerical segments