Merge pull request #565 from player-ui/bugfix/quoted-bindings

Fix Binding Instantiation of Escaped Numerical Bindings

CHANGELOG.md

@@ -28,12 +28,6 @@
 - Jeremiah Zucker ([@sugarmanz](https://github.com/sugarmanz))
 - Ketan Reddy ([@KetanReddy](https://github.com/KetanReddy))
 
----
-
-# 0.10.2 (Wed Dec 04 2024)
-
-
-
 ---
 
 # 0.10.0 (Wed Dec 04 2024)

core/player/src/binding/__tests__/binding.test.ts

@@ -111,3 +111,13 @@ describe("descendent binding", () => {
     ]);
   });
 });
+
+describe("Edge cases", () => {
+  it("Bindings with escaped numbers", () => {
+    expect(new BindingInstance("foo.01.bar").asArray()).toStrictEqual([
+      "foo",
+      "01",
+      "bar",
+    ]);
+  });
+});

core/player/src/binding/__tests__/parser.bench.ts

@@ -1,6 +1,6 @@
 import { bench, describe } from "vitest";
 import get from "dlv";
-import { getBindingSegments } from "..";
+import { BindingInstance, getBindingSegments } from "..";
 import { testCases, testModel } from "./resolver.test";
 import { parseCustom, ParserSuccessResult } from "../../binding-grammar";
 import { resolveBindingAST } from "../resolver";
@@ -20,3 +20,23 @@ describe("parser benchmarks", () => {
     { iterations: 10000 },
   );
 });
+
+describe("binding creation benchmarks", () => {
+  testCases.map(
+    ([input, expectedOutput]) => {
+      bench(`Resolving binding: ${input}`, () => {
+        const parsedBinding = parseCustom(input);
+        const result = resolveBindingAST(
+          (parsedBinding as ParserSuccessResult).path,
+          {
+            getValue: (path) => get(testModel, getBindingSegments(path) as any),
+            convertToPath: (p) => p,
+            evaluate: () => undefined,
+          },
+        );
+        const bi = new BindingInstance(result.path);
+      });
+    },
+    { iterations: 10000 },
+  );
+});

core/player/src/binding/binding.ts

@@ -53,7 +53,9 @@ export class BindingInstance {
       }
 
       const tryNum = Number(segment);
-      return isNaN(tryNum) ? segment : tryNum;
+      // test to make sure turning a numerical string to a number doesn't change
+      // the actual value of the string by getting rid of a leading zero
+      return isNaN(tryNum) || String(tryNum) !== segment ? segment : tryNum;
     });
     Object.freeze(this.split);
     this.joined = this.split.join(".");

package.json

@@ -188,7 +188,7 @@
     "ts-node": "^10.9.2",
     "tsconfig-paths-webpack-plugin": "^4.1.0",
     "tslib": "^2.6.2",
-    "tsup": "^8.0.1",
+    "tsup": "^8.3.5",
     "typescript": "5.5.3",
     "unist-util-visit": "^5.0.0",
     "uuid": "^8.3.2",

scripts/next-changelogs.js

@@ -3,7 +3,7 @@
 /* eslint-disable no-await-in-loop */
 const { execSync } = require("child_process");
 
-const getLatestReleaseTag = () => {
+const getLatestReleaseTags = () => {
   const tags = execSync("git tag --sort=-creatordate", { encoding: "utf8" });
   return tags
     .split("\n")
@@ -12,21 +12,25 @@ const getLatestReleaseTag = () => {
       (tag) =>
         tag.includes("-next.") ||
         tag.match(/^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)$/),
-    )[0];
+    );
 };
 
 class NextChangelogsPlugin {
   name = "next-changelogs";
 
   apply(auto) {
     auto.hooks.next.tapPromise(this.name, async ({ dryRun }) => {
-      const latestRelease = getLatestReleaseTag();
+      const [latest, second] = getLatestReleaseTags();
       if (dryRun) {
         auto.logger.log.info(
           `Dry run: making changelog from last release: ${latestRelease}`,
         );
       } else {
-        await auto.changelog({ from: latestRelease });
+        await auto.changelog({
+          from: second,
+          to: latest,
+          title: `${latest} ${new Date().toDateString()}`,
+        });
         execSync(`git push ${auto.remote} ${auto.baseBranch}`);
       }
     });