Skip to content

Commit

Permalink
import core asset reference
Browse files Browse the repository at this point in the history
  • Loading branch information
cehan-Chloe committed Feb 13, 2025
1 parent 3f4d1b8 commit 764dd6a
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion plugins/data-change-listener/core/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ js_pipeline(
":node_modules/@player-ui/asset-transform-plugin",
":node_modules/@player-ui/common-types-plugin",
":node_modules/@player-ui/partial-match-registry",
":node_modules/@player-ui/reference-assets-plugin-react",
":node_modules/@player-ui/reference-assets-plugin",
":node_modules/@player-ui/common-expressions-plugin",
"//:node_modules/@testing-library/react",
"//:vitest_config",
Expand Down
2 changes: 1 addition & 1 deletion plugins/data-change-listener/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"@player-ui/partial-match-registry": "workspace:*",
"@player-ui/asset-transform-plugin": "workspace:*",
"@player-ui/common-types-plugin": "workspace:*",
"@player-ui/reference-assets-plugin-react": "workspace:*",
"@player-ui/reference-assets-plugin": "workspace:*",
"@player-ui/common-expressions-plugin": "workspace:*"
}
}
6 changes: 3 additions & 3 deletions plugins/data-change-listener/core/src/__tests__/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { CommonTypesPlugin } from "@player-ui/common-types-plugin";
import { AssetTransformPlugin } from "@player-ui/asset-transform-plugin";
import { Registry } from "@player-ui/partial-match-registry";
import { DataChangeListenerPlugin } from "../index";
import { ReferenceAssetsPlugin } from "@player-ui/reference-assets-plugin-react";
import { ReferenceAssetsPlugin } from "@player-ui/reference-assets-plugin";
import { CommonExpressionsPlugin } from "@player-ui/common-expressions-plugin";

/** Test transform function to add validation to asset */
Expand Down Expand Up @@ -569,7 +569,7 @@ describe("Data-Change-Listener with array modification", () => {
return player.getState() as InProgressState;
}

it("should call expression evaluator when an array that is tracked changes", () => {
it("should call expression evaluator and data change listener when an array that is tracked changes", () => {
player = new Player({
plugins: [
new CommonTypesPlugin(),
Expand Down Expand Up @@ -610,7 +610,7 @@ describe("Data-Change-Listener with array modification", () => {
expect(testExpression).toHaveBeenCalledWith("array has changed 1,2,3,4");
});

it("should call expression evaluator when count is tracked changes", () => {
it("should call expression evaluator and data change listener when count is changes", () => {
player = new Player({
plugins: [
new CommonTypesPlugin(),
Expand Down
4 changes: 2 additions & 2 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 764dd6a

Please sign in to comment.