Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds code-editor asset #17

Merged
merged 3 commits into from
Apr 30, 2024
Merged

feat: adds code-editor asset #17

merged 3 commits into from
Apr 30, 2024

Conversation

rafbcampos
Copy link
Collaborator

@rafbcampos rafbcampos commented Apr 24, 2024

Description

Adds code-editor asset that can be used to edit JSON content and call an expression on changes.

Change Type

  • patch
  • minor
  • major

Screenshot 2024-04-29 at 4 40 19 PM

Release Notes

Added code-editor asset that can be used to edit JSON content and call an expression on change:

import { CodeEditor } from "@devtools-ui/plugin";

// and use it to define your Player-UI content:
myFlow = {
  id: "my_flow",
  views: [<CodeEditor exp={e`my_expression`} binding={b`my_binding`} />],
};
📦 Published PR as canary version: 0.1.0--canary.17.880

Try this version out locally by upgrading relevant packages to 0.1.0--canary.17.880

Version

Published prerelease version: 0.1.0-next.0

Changelog

Release Notes

feat: adds code-editor asset (#17)

Added code-editor asset that can be used to edit JSON content and call an expression on change:

import { CodeEditor } from "@devtools-ui/plugin";

// and use it to define your Player-UI content:
myFlow = {
  id: "my_flow",
  views: [<CodeEditor exp={e`my_expression`} binding={b`my_binding`} />],
};

🚀 Enhancement

🐛 Bug Fix

Authors: 5

@rafbcampos rafbcampos self-assigned this Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 25.38462% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 28.91%. Comparing base (5f0d380) to head (8326cd6).

Files Patch % Lines
code-editor/src/transform/index.ts 0.00% 72 Missing ⚠️
code-editor/src/component/index.tsx 0.00% 20 Missing ⚠️
code-editor/src/index.ts 0.00% 4 Missing ⚠️
stacked-view/src/component/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   29.27%   28.91%   -0.36%     
==========================================
  Files          54       58       +4     
  Lines        1199     1328     +129     
  Branches        4        4              
==========================================
+ Hits          351      384      +33     
- Misses        847      943      +96     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafbcampos
Copy link
Collaborator Author

/canary

@rafbcampos
Copy link
Collaborator Author

/canary

@rafbcampos rafbcampos merged commit 2995340 into main Apr 30, 2024
7 of 9 checks passed
@rafbcampos rafbcampos deleted the console-editor branch April 30, 2024 15:44
@@ -0,0 +1,90 @@
# @devtools-ui/code-editor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nextjs routing makes /code-editor available for routing, but for this document to be listed on the side navigation bar it needs to get listed on these routes around here. This is something the updated gen: asset can take care of for you in future assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants