Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/devtools site #14

Merged
merged 15 commits into from
Apr 10, 2024
Merged

Docs/devtools site #14

merged 15 commits into from
Apr 10, 2024

Conversation

lexfm
Copy link
Contributor

@lexfm lexfm commented Apr 4, 2024

Change Type (required)

First implementation of Devtools assets docs site.

  • patch
  • minor
  • major

Copy link
Collaborator

@rafbcampos rafbcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As we discussed, we'll handle the Bazel BUILD on another PR and set the content of the final docs.
Before setting it as ready for review, please make sure to remove unused imports (e.g., DOCS_BASE_URL at Navigation.tsx, withRouter, Fragment and parse at mdx-component.tsx).

@lexfm lexfm force-pushed the docs/devtools-site branch from aa2e40f to 02627ef Compare April 10, 2024 17:20
@lexfm lexfm marked this pull request as ready for review April 10, 2024 19:35
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.27%. Comparing base (b5ef862) to head (bddf785).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   29.27%   29.27%           
=======================================
  Files          54       54           
  Lines        1199     1199           
  Branches        4        4           
=======================================
  Hits          351      351           
  Misses        847      847           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafbcampos rafbcampos changed the title Docs/devtools site (Draft) Docs/devtools site Apr 10, 2024
@rafbcampos rafbcampos merged commit bec1893 into main Apr 10, 2024
9 checks passed
@rafbcampos rafbcampos deleted the docs/devtools-site branch April 10, 2024 19:46
@intuit-svc intuit-svc mentioned this pull request Apr 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants