Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double click updates #379

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Double click updates #379

merged 3 commits into from
Jan 15, 2025

Conversation

slimbuck
Copy link
Member

This PR:

  • fixes a bug where gizmo is placed when double clicking, even when no gizmo was selected
  • adds a 3d cursor label to the viewport which shows the location of the double click
    • click the text to copy it to clipboard

Notes

  • it would be awesome to extend this functionality so SuperSplat supports arbitrary markers with data attached
Screenshot 2025-01-15 at 12 03 05

@slimbuck slimbuck added the enhancement New feature label Jan 15, 2025
@slimbuck slimbuck requested a review from a team January 15, 2025 12:03
@slimbuck slimbuck self-assigned this Jan 15, 2025
willeastcott
willeastcott approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Although maybe the double-click coordinate text element should be hidden once the user has clicked somewhere some time after the double-click.

@slimbuck slimbuck merged commit b008eca into playcanvas:main Jan 15, 2025
2 checks passed
@slimbuck slimbuck deleted the dbl-dev branch January 15, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slimbuck @willeastcott