Fix undo/redo keyboard shortcut #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Dec 30, 2024
|
Has this already been released? I ran into random UNDO-issues yesterday. |
|
@simonbethke No, I believe we are aiming to deploy the fix either today or tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232
This PR adds an option to register a keyboard event for capture phase (instead of the default bubble phase). Capture phase handlers are fired first, before any child listeners, allowing global overrides of events.
This is useful for undo/redo which is also handled by entry boxes and results in confusing undo/redo behaviour depending on the currently focused dom element.
This PR also stops propagation of the recognised up and down events and also prevents the default event firing. This is required for capture phase handler, but is probably also desirable for bubble events. This change needs testing.