ci setup for npm publishing #46 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @willeastcott, Are there any other tweaks you'd like before we proceed with an NPM publish? |
|
@nyan-left No, I think we're good to go. I just need to have @matthewvroman transfer the |
|
OK, the NPM package has been transferred. 🎉 |
willeastcott
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46 #30
Changelog
pcsyncandpcwatchto standardbinfolder.binfolder is now linted.eslintpath inpackage.jsonlintscript.Remarks
The playcanvas-sync project seems to have linting setup, but there are a lot of errors.Resolving these issues and running the linter before publishing is out of scope for this PR/issue.
The linting stage can be commented back in once the issues are resolved. I propose the linting stage also runs on any pull requests in the future.
@willeastcott This PR will require you to set up a secret on this repo or your organisation called
NPM_TOKENhttps://docs.npmjs.com/about-access-tokens#about-granular-access-tokensMany thanks :)