Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextEditView: Soft keyboard now opens on first tap and cursor is positioned correctly. #71

Closed
wants to merge 2 commits into from
Closed

TextEditView: Soft keyboard now opens on first tap and cursor is positioned correctly. #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
790cda6
Soft keyboard now opens on first tap and cursor is positioned correctly.
jsdevlover Nov 15, 2015
7cd40ff
Corrected typo.
jsdevlover Nov 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/platforms/native/EditText.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ exports = Class(function() {
if (this._opts.closeOnDone === false) {
closeOnDone = false;
}

//Makes sure soft keyboard is opened on first tap.
NATIVE.call('softKeyboard.open', {});

NATIVE.call('editText.focus', {
id: this._id,
paddingLeft: this._opts.paddingLeft * scale,
Expand All @@ -139,8 +141,11 @@ exports = Class(function() {
hasForward: hasForward,
closeOnDone: closeOnDone
});

//cursorPos);
//FIXME HACK: cursorPos property above doesn't seem to set the cursor position correctly.
//This sets the cursor at the last position if TextEditView contains some text while focusing.
NATIVE.call('editText.setText', {
text: currentVal
});
}

this.hasFocus = function() {
Expand Down