Change for ratio to 2:1 #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rampr
reviewed
May 9, 2017
package.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "author": "The Game Closure DevKit Team", | |||
| "name": "native-android", | |||
| "description": "Native-Android DevKit addon for building for the Android platform", | |||
| "version": "1.0.22", | |||
|
We shouldn't merge this unless it is tested. I'm not sure changing manifest without testing would have any side effects |
|
I tested it on my phone @rampr It doesn't create any issues with the build |
|
Tested on 2:1 simulator, works except for the hashcube loading screen image because of the aspect ratio |
|
how to solve the loading screen issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't been able to test it yet, emulator isn't working but this does what google asked us to do. Still figuring out a way to test