Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer version should be a valid constraint not ^2.1 #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rfay
Copy link
Contributor

@rfay rfay commented Oct 24, 2024

Description

The current constraint here is invalid, composer has never supported a 2.1 branch (there is a 2.2). I'm not sure how this can work, but it seems that platform may try and fail to use 2.1, so just uses 2.8.x currently instead.

Related Issue

This project only accepts pull requests related to open issues.

  • If suggesting a new feature or change, please discuss it in an issue first
  • If fixing a bug, there should be an issue describing it with steps to reproduce it following the bug report guide
  • If you're suggesting a feature, please follow the feature request guide by clicking on issues

Please drop a link to the issue here:

Motivation and Context

Use a valid composer version.

How Has This Been Tested?

Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following list, and put an x in all the boxes that apply. If you're unsure about what any of these mean, don't hesitate to ask. We're here to help!

  • I have read the contribution guide
  • I have created an issue following the issue guide
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

The current constraint here is invalid, composer has never supported a 2.1 branch (there is a 2.2). I'm not sure how this can work, but it seems that platform may try and fail to use 2.1, so just uses 2.8.x currently instead.
@rfay rfay changed the title Composer version should be a valid constraint Composer version should be a valid constraint not ^2.1 Oct 24, 2024
@rfay
Copy link
Contributor Author

rfay commented Oct 24, 2024

Platform docs say the same here: https://docs.platform.sh/languages/php.html#dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant