Fix bug in special handling of closing the last tab #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This app currently handles the closing of the last tab specially. When closing a tab, the typical behaviors are: - Ask user for confirmation if the settings say so. - After the tab is closed, it is gone. If I quite the app and then reopen it, that tab will not show up again. However, when closing the last tab, the behavior is: - No user confirmation is requested, even if the settings say so. - If I quite the app and then reopen it, the closed tab comes back. This commit fixes this behavior.
|
@wanderor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This app currently handles the closing of the last tab specially.
When closing a tab, the typical behaviors are:
However, when closing the last tab, the behavior is:
This commit fixes this behavior.