Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in project #772

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix warnings in project #772

merged 1 commit into from
Jan 4, 2024

Conversation

joshuatbrown
Copy link
Contributor

Fixes #771. I found that some of the warnings are false alarms, so those can't actually be fixed. Specifically, these are not real warnings:

No calls to throwing functions occur within 'try' expression

The other warnings are fixed.

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2024

CLA assistant check
All committers have signed the CLA.

@martindsq
Copy link
Member

Nice!

What Xcode version are you using? I recall seeing those warnings but they don't appear for me anymore and I updated it recently to 15.1.

You can add a label right here to mark this PR as "skips changelog" so the check doesn't fail.

Everything looks good to me.

@joshuatbrown
Copy link
Contributor Author

What Xcode version are you using? I recall seeing those warnings but they don't appear for me anymore and I updated it recently to 15.1.

Thanks for the review, @martindsq! I'm using 15.1; not sure why the warnings appear for me and not you, but that's not too surprising to me. Xcode is just inconsistent sometimes.

Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh! I think some of these warnings were in the unit test target and would only show if you have run the unit tests after opening Xcode.

The No calls to throwing functions occur within 'try' expression is a long standing one that stresses me out. Basically multiple Swift Packages that we import define functions with the same name, and depending on the order they load in a different version can be used. What's worse is that the implementations aren't equivalent 😭 it caused a bug in the main target that I fixed somehow, but I couldn't get it fixed in the unit test target. I filed #777 to address these in the future.

@mplorentz mplorentz merged commit a9dba17 into main Jan 4, 2024
6 of 7 checks passed
@mplorentz mplorentz deleted the fix-warnings branch January 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Xcode project warnings
4 participants