Remove old NosNotification objects #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatbrown
reviewed
Jan 2, 2024
mplorentz
requested changes
Jan 4, 2024
| return fetchRequest | ||
| } | ||
|
|
||
| static func cutoffDate() -> Date { |
There was a problem hiding this comment.
This is named very similarly to PushNotificationService.notificationCutoff but performs a slightly different function which I think I will find confusing in the future.
NosNotification.cutoffDate()is two months beforeDate.now, and is used to delete old notifications from the db.PushNotificationService.notificationCutoffis used to limit which notifications are displayed to the user as push notifications. When the user first opens the app it is initialized to Date.now. This is to prevent us showing tons of push notifications on first login. Then after that it is set to the date of the last notification that we showed.
Could we make these names more specific and maybe document the two vars? I think this one could be staleNotificationCutoff and the other could be showPushNotificationsAfter, but I'm open to other ideas too.
mplorentz
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#424
The idea is as follows, we delete all notifications before a specific cutoff date (I set it to two months earlier than now) and, also, we don't create notifications before that cutoff date. These notifications are still displayed in the notifications view because that view is populated differently, with a request to Event table.
The NosNotification model didn't have a date to use for that nor a reference to the event (that could be nullified if the event is removed), so I edited the coredatamodel to add a createdDate for the NosNotification and matched it to the date of the event.
I removed an unused function I found as well.