Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NIP-96 and NIP-98 for file uploads #1220

Merged
merged 13 commits into from
Jun 6, 2024

Conversation

joshuatbrown
Copy link
Contributor

@joshuatbrown joshuatbrown commented Jun 5, 2024

Issues covered

#1208

Description

Uploads photos and videos using the file storage API from nostr.build as described in NIP-96.

How to test

  1. Tap Post
  2. Tap the image upload button
  3. Select an image
  4. Observe URL
  5. Post the post
  6. Observe your image in a post

Screenshots/Video

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-06.at.17.50.04.mp4

@joshuatbrown joshuatbrown marked this pull request as ready for review June 6, 2024 21:48
@joshuatbrown joshuatbrown changed the title Start implementing NIP-96 for file uploads Implement NIP-96 and NIP-98 for file uploads Jun 6, 2024
Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for me! I tested photo and video upload. We discussed making a few changes in another PR but this is a great hotfix 👍

@joshuatbrown joshuatbrown added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit f61abc8 Jun 6, 2024
5 checks passed
@joshuatbrown joshuatbrown deleted the feature/nip-96-file-storage branch June 6, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants