Disable testOutOfNetwork, which is flaky #1217
Merged
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
Disables
SocialGraphTests.testOutOfNetwork(), which should be fixed and reenabled in #671.Description
In addition to disabling another flaky test (which failed here), I moved all disabled tests to the test plan. You can see disabled tests in the test navigator in Xcode -- they're grayed out -- and you can filter by Disabled at the bottom:
This also gives us the ability to run disabled tests manually in Xcode by clicking the run icon next to them, or by filtering (as shown above), selecting them, and running them all.
How to test
Run unit tests