Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SwiftLint build phase before compile #1216

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Move SwiftLint build phase before compile #1216

merged 1 commit into from
Jun 4, 2024

Conversation

joshuatbrown
Copy link
Contributor

Issues covered

#734

Description

Moves the SwiftLint build phase before compile. This results in getting SwiftLint warnings much earlier.

How to test

  1. Open a file
  2. Add a bunch of line breaks anywhere
  3. Build
  4. Observe SwiftLint warnings much earlier than before

@joshuatbrown joshuatbrown enabled auto-merge June 4, 2024 14:36
@joshuatbrown joshuatbrown added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit b7ab5a2 Jun 4, 2024
7 of 8 checks passed
@joshuatbrown joshuatbrown deleted the devx/move-swiftlint-phase branch June 4, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mplorentz mplorentz mplorentz approved these changes

@martindsq martindsq Awaiting requested review from martindsq martindsq is a code owner

Assignees
No one assigned
Labels
Skip-Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuatbrown @mplorentz