disable flaky testOutOfNetwork; move all disabled tests to test plan

planetary-social · Jun 4, 2024 · aebabca · aebabca
1 parent 636b555
commit aebabca
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/NosTests/Controller/SocialGraphTests.swift b/NosTests/Controller/SocialGraphTests.swift
@@ -17,9 +17,7 @@ final class SocialGraphTests: CoreDataTestCase {
     }
 
     /// The `XCTExpectFailure` below does _not_ work in CI. That is, when the test fails, CI still fails.
-    /// Since all tests must start with the word "test", prefixing it with "disable" is a clear way to disable it
-    /// until we can fix the intermittent failure.
-    func disable_testOneFollower() async throws {
+    func testOneFollower() async throws {
         XCTExpectFailure("This test is failing intermittently, see #671", options: .nonStrict())
 
         // Arrange
@@ -44,9 +42,7 @@ final class SocialGraphTests: CoreDataTestCase {
     }
 
     /// The `XCTExpectFailure` below does _not_ work in CI. That is, when the test fails, CI still fails.
-    /// Since all tests must start with the word "test", prefixing it with "disable" is a clear way to disable it
-    /// until we can fix the intermittent failure.
-    func disable_testFollow() async throws {
+    func testFollow() async throws {
         XCTExpectFailure("This test is failing intermittently, see #671", options: .nonStrict())
 
         // Arrange
@@ -73,9 +69,7 @@ final class SocialGraphTests: CoreDataTestCase {
     }
 
     /// The `XCTExpectFailure` below does _not_ work in CI. That is, when the test fails, CI still fails.
-    /// Since all tests must start with the word "test", prefixing it with "disable" is a clear way to disable it
-    /// until we can fix the intermittent failure.
-    func disable_testTwoFollows() async throws {
+    func testTwoFollows() async throws {
         XCTExpectFailure("This test is failing intermittently, see #671", options: .nonStrict())
 
         // Arrange

diff --git a/NosTests/UnitTests.xctestplan b/NosTests/UnitTests.xctestplan
@@ -28,6 +28,12 @@
   },
   "testTargets" : [
     {
+      "skippedTests" : [
+        "SocialGraphTests\/testFollow()",
+        "SocialGraphTests\/testOneFollower()",
+        "SocialGraphTests\/testOutOfNetwork()",
+        "SocialGraphTests\/testTwoFollows()"
+      ],
       "target" : {
         "containerPath" : "container:Nos.xcodeproj",
         "identifier" : "C9DEBFE3298941020078B43A",