remove worldboss reward mail #6958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-doobu
requested review from
sonohoshi and
jonny-jeahyunchoi
as code owners
jonny-jeahyunchoi
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
빌드 새로 뽑히는 경우 290에 머지, 아닌 경우 대기했다 백머지 후 dev에 머지하겠습니다
This pull request includes changes to the handling of world boss reward mails in the
ActionRenderHandlerandMailPopupclasses. The most important changes include the removal of specific methods and the deprecation of a method.Changes to
ActionRenderHandler:LocalLayerModifier.AddNewMailandOneLineSystem.Pushafter claiming a world boss reward. (nekoyume/Assets/_Scripts/Blockchain/ActionRenderHandler.cs)Changes to
MailPopup:Read(WorldBossRewardMail worldBossRewardMail)method and removed its body, indicating it should no longer be used. (nekoyume/Assets/_Scripts/UI/Widget/Popup/MailPopup.cs)