Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

world boss fe-qa 1 #6913

Merged
merged 10 commits into from
Mar 4, 2025
Merged

world boss fe-qa 1 #6913

merged 10 commits into from
Mar 4, 2025

Conversation

eugene-doobu
Copy link
Member

@eugene-doobu eugene-doobu commented Feb 28, 2025

This pull request includes several changes to the nekoyume/Assets/Resources/UI/Prefabs/UI_WorldBoss.prefab and related files, primarily focusing on modifying UI elements, updating reward handling, and refactoring code for better maintainability. The most important changes include removing and modifying GameObject components, updating reward handling in the ActionRenderHandler.cs file, and refactoring the WorldBossMenu.cs file.

Prefab Modifications:

  • Removed multiple GameObject components and adjusted properties in UI_WorldBoss.prefab, including RectTransform, CanvasRenderer, and MonoBehaviour. [1] [2] [3] [4] [5] [6]

Reward Handling:

  • Updated the ResponseClaimWorldBossReward method to handle rewards more effectively, including processing fungible asset values and items, and displaying rewards on the MailRewardScreen. [1] [2]

UI Updates:

  • Changed the m_IsActive property of GameObjects in UI_WorldBossDetail.prefab to toggle their active state. [1] [2]
  • Updated text fields and localization keys in UI_WorldBossDetail.prefab to use the UI_CLAIM_REWARD key. [1] [2]

Code Refactoring:

  • Refactored WorldBossMenu.cs to introduce properties for managing grade rewards and world boss state, and added methods to set notification states and subscribe to state changes. [1] [2] [3]
  • Updated WorldBossBattleRewardItem.cs to use BigInteger for crystal values.
  • Modified WorldBossReward.cs to use the WorldBossStates.Set method for retrieving data.

Submodule Update:

  • Updated the submodule commit for lib9c.

@eugene-doobu eugene-doobu changed the title set red-dot world boss fe-qa 1 Mar 4, 2025
@eugene-doobu eugene-doobu marked this pull request as ready for review March 4, 2025 04:42
@eugene-doobu eugene-doobu merged commit 5de5f66 into development Mar 4, 2025
14 checks passed
@eugene-doobu eugene-doobu deleted the feature/world-boss-fe-qa branch March 4, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment