-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
world boss fe-qa 1 #6913
Merged
Merged
world boss fe-qa 1 #6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 28, 2025
This was
linked to
issues
Mar 4, 2025
This was
unlinked from
issues
Mar 4, 2025
This was
unlinked from
issues
Mar 4, 2025
This was
linked to
issues
Mar 4, 2025
This was
linked to
issues
Mar 4, 2025
jonny-jeahyunchoi
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
nekoyume/Assets/Resources/UI/Prefabs/UI_WorldBoss.prefab
and related files, primarily focusing on modifying UI elements, updating reward handling, and refactoring code for better maintainability. The most important changes include removing and modifying GameObject components, updating reward handling in theActionRenderHandler.cs
file, and refactoring theWorldBossMenu.cs
file.Prefab Modifications:
UI_WorldBoss.prefab
, includingRectTransform
,CanvasRenderer
, andMonoBehaviour
. [1] [2] [3] [4] [5] [6]Reward Handling:
ResponseClaimWorldBossReward
method to handle rewards more effectively, including processing fungible asset values and items, and displaying rewards on theMailRewardScreen
. [1] [2]UI Updates:
m_IsActive
property of GameObjects inUI_WorldBossDetail.prefab
to toggle their active state. [1] [2]UI_WorldBossDetail.prefab
to use theUI_CLAIM_REWARD
key. [1] [2]Code Refactoring:
WorldBossMenu.cs
to introduce properties for managing grade rewards and world boss state, and added methods to set notification states and subscribe to state changes. [1] [2] [3]WorldBossBattleRewardItem.cs
to useBigInteger
for crystal values.WorldBossReward.cs
to use theWorldBossStates.Set
method for retrieving data.Submodule Update:
lib9c
.